@khaosdoctor Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

• keychain (new!) — on npm, on unpkg
  • 1 added owner: ✎@khaosdoctor

Code Reviews

This PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.

You can test the changes of this PR in the Playground.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Only a DT maintainer can approve changes when there are new packages added

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

{
  "type": "info",
  "now": "-",
  "pr_number": 64842,
  "author": "khaosdoctor",
  "headCommitOid": "9c0fc4b5e599e3e0fdc7bac1dca4a792ebb6d709",
  "mergeBaseOid": "c8d68f04d24f4354b2e7d018966483333958c528",
  "lastPushDate": "2023-03-23T14:07:13.000Z",
  "lastActivityDate": "2023-03-23T20:30:36.000Z",
  "mergeOfferDate": "2023-03-23T20:06:10.000Z",
  "mergeRequestDate": "2023-03-23T20:30:36.000Z",
  "mergeRequestUser": "khaosdoctor",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "keychain",
      "kind": "add",
      "files": [
        {
          "path": "types/keychain/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/keychain/keychain-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/keychain/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/keychain/tslint.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [],
      "addedOwners": [
        "khaosdoctor"
      ],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "peterblazejewicz",
      "date": "2023-03-23T20:05:23.000Z",
      "isMaintainer": true
    },
    {
      "type": "stale",
      "reviewer": "sandersn",
      "date": "2023-03-21T23:41:14.000Z",
      "abbrOid": "92862ae"
    }
  ],
  "mainBotCommentID": 1478506775,
  "ciResult": "pass"
}

🔔 @khaosdoctor — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

@khaosdoctor The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

keychain (unpkg)

was missing the following properties:

1. executablePath

Generated by 🚫 dangerJS against 9c0fc4b

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

This is because the module is exported as a default export, I've tested this in a real CLI to make sure the types were ok

@khaosdoctor One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

@khaosdoctor The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

Forgot to run the tests 😅

@sandersn Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@peterblazejewicz, @sandersn Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@khaosdoctor: Everything looks good here. I am ready to merge this PR (at 9c0fc4b) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

Ready to merge